Fixes #3044 Fixes #3062: correct the module installation and reporting on the technique apache2 installation #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Modules | ||
| "apache_modules" slist => {&APACHE_MODULES: { "expires", "alias", "&it&" };separator=", "&}; | ||
| # Modules that are are checked if the list of module is defined | ||
| "apache_modules" slist => { "expires", "alias", &APACHE_MODULES: { "&it&" };separator=", "& }; |
There was a problem hiding this comment.
Why not re-use the list above that you added ("apache_modules_defined"), rather than have more StringTemplate replacement here, for a variable we already have the values of? This seems counter productive to me - we should have as much CFEngine-pure code as possible.
|
Aside from my comments inline in the diff, this change looks good to me. Thanks for clarifying it Nico! |
|
Apart from one typo in the "donfigured", this is fine. Please fix typo and go ahead and merge! |
…g on the technique apache2 installation
ncharles
added a commit
that referenced
this pull request
Jan 4, 2013
…ll_and_reporting_3062_3044 Fixes #3044 Fixes #3062: correct the module installation and reporting on the technique apache2 installation
jooooooon
added a commit
to jooooooon/rudder-techniques
that referenced
this pull request
Jan 16, 2013
…nge_rsyslog_initd_invocation_to_restart_in_packaging Fixes #3176: Change every rsyslog init.d invocation to restart instead o...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the issues of http://www.rudder-project.org/redmine/issues/3044 and http://www.rudder-project.org/redmine/issues/3062