Fixes #11226: Allowed network 0.0.0.0/0 is not currently supported by Apache #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Nov 17, 2017
| @@ -41,6 +45,14 @@ bundle agent root_networks_check | |||
|
|
|||
| "index" slist => getindices("network_file"); | |||
|
|
|||
| has_all_granted:: | |||
| "network_acl[nodes_22]" string => "Allow from all${const.n}${nodes_generate_22}"; | |||
There was a problem hiding this comment.
Why adding other allow directives if we allow from all?
|
Commit modified |
peckpeck
force-pushed
the
bug_11226/allowed_network_0_0_0_0_0_is_not_currently_supported_by_apache
branch
from
2675a4e
to
501d678
Compare
amousset
reviewed
Nov 17, 2017
| @@ -41,6 +45,14 @@ bundle agent root_networks_check | |||
|
|
|||
| "index" slist => getindices("network_file"); | |||
|
|
|||
| has_all_granted:: | |||
| "network_acl[nodes_22]" string => "Allow from all$"; | |||
|
Commit modified |
peckpeck
force-pushed
the
bug_11226/allowed_network_0_0_0_0_0_is_not_currently_supported_by_apache
branch
from
501d678
to
4334077
Compare
|
OK, merging this PR |
peckpeck
deleted the
bug_11226/allowed_network_0_0_0_0_0_is_not_currently_supported_by_apache
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11226