Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14313: Port MOTD Technique to DSC #1414

Conversation

ncharles
Copy link
Member

@fanf
Copy link
Member

fanf commented Mar 26, 2019

@Fdall would you take a look please?

"any"
usebundle => rudder_common_report("${service_name}", "log_repaired", "${trackingkey}", "MOTD Configuration", "None", "The ${service_name} file was absent, it will be created");

&if(NOVA)&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could remove this part

@ncharles
Copy link
Member Author

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1414
-- Your faithful QA
Kant merge: "Morality is not the doctrine of how we may make ourselves happy, but how we may make ourselves worthy of happiness."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/8601/console)

@ncharles
Copy link
Member Author

OK, squash merging this PR

@ncharles ncharles force-pushed the ust_14313/port_motd_technique_to_dsc branch from 108f3c6 to c64dfdc Compare April 19, 2019 10:06
@ncharles ncharles merged commit c64dfdc into Normation:branches/rudder/4.3 Apr 19, 2019
@ncharles
Copy link
Member Author

OK, merging this PR

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants