Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #15029: It's not possible to use $(match.o) anymore in directives/techniques #1460

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Fixes #15029: It's not possible to use $(match.o) anymore in directives/techniques #1460

merged 1 commit into from
Jul 23, 2019

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Jul 12, 2019

amousset
amousset reviewed Jul 12, 2019
View reviewed changes
techniques/fileDistribution/checkGenericFileContent/8.0/checkGenericFileContent.st Outdated
@@ -411,14 +412,14 @@ ${section_end}"


replace_patterns:
replace_lines.replace_lines_destination_defined::
replace_lines.(replace_lines_destination_defined|!no_replace_lines_destination_defined.!replace_lines_destination_defined)::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add parentheses to make the expression clearer?

@Fdall
Copy link
Contributor Author

Fdall commented Jul 16, 2019

PR updated with a new commit

@Fdall Fdall requested a review from amousset July 23, 2019 09:21
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1460
-- Your faithful QA
Kant merge: "In law a man is guilty when he violates the rights of others. In ethics he is guilty if he only thinks of doing so."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/12667/console)

@Fdall
Copy link
Contributor Author

Fdall commented Jul 23, 2019

OK, squash merging this PR

@Fdall Fdall force-pushed the bug_15029/it_s_not_possible_to_use_match_o_anymore_in_directives_techniques branch from 84b4743 to 6992489 Compare July 23, 2019 09:57
@Fdall Fdall merged commit 6992489 into Normation:branches/rudder/5.0 Jul 23, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amousset amousset amousset approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fdall @Normation-Quality-Assistant @amousset