Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #18286 #1626

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Conversation

amousset
Copy link
Member

@amousset amousset commented Oct 5, 2020

No description provided.

@amousset
Copy link
Member Author

amousset commented Oct 5, 2020

PR updated with a new commit

@amousset
Copy link
Member Author

amousset commented Oct 5, 2020

PR updated with a new commit

@amousset
Copy link
Member Author

amousset commented Oct 5, 2020

PR updated with a new commit

@amousset
Copy link
Member Author

amousset commented Oct 5, 2020

PR updated with a new commit

trustkeysfrom => {
@{def.acl} ,
}; #trustkey allows the exchange of keys
};
# our policy server should already be trusted at bootstraping
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at bootstraping -> after bootstraping is done

@amousset
Copy link
Member Author

amousset commented Oct 5, 2020

PR updated with a new commit

@amousset
Copy link
Member Author

amousset commented Oct 6, 2020

PR updated with a new commit

@amousset
Copy link
Member Author

amousset commented Oct 6, 2020

PR updated with a new commit

@@ -428,3 +451,10 @@ body perms u_mog(mode,user,group)
owners => { "${user}" };
groups => { "${group}" };
}


bundle edit_line rudder_update_lines_present(lines)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all other bodys/bundle have a more specific name. I fear collision with a name that common
Could you name it u_rudder_update_lines_present ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used

@amousset
Copy link
Member Author

amousset commented Oct 8, 2020

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1626
-- Your faithful QA
Kant merge: "Live your life as though your every act were to become a universal law."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/30716/console)

@amousset
Copy link
Member Author

amousset commented Oct 8, 2020

OK, squash merging this PR

@amousset amousset merged commit aa7a10b into Normation:branches/rudder/5.0 Oct 8, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants