Fixes #18695: Create a technique to manage yum repository #1645
Conversation
|
Yum repos have several option for url: Should we let the user choose which field to set ? |
ncharles
force-pushed
the
bug_18695/create_a_technique_to_manage_yum_repository
branch
from
e38aa72
to
145142d
Compare
|
Commit modified |
| if => "!delete_repo_${index}"; | ||
|
|
||
| # Deletion of repo | ||
| "delete repo ${index}" usebundle => file_absent("${filename[${index}]}"), |
There was a problem hiding this comment.
this is overzealous as it may delete several repos if they are in the same file
There was a problem hiding this comment.
i could make a file promise, that would select the region, and delete all lines matching *, plus deleting the region.
but it may leave nearly empty files
So another idea would be to count the section in a file, with a grep -rc '^[.*]$' /etc/yum.repos.d/
if count is 1, then delete the file, else clean it
this would probably be another bundle
Fixes #18695: Create a technique to manage yum repository
|
PR updated with a new commit |
Fixes #18695: Create a technique to manage yum repository
|
PR updated with a new commit |
…epository Fixes #18695: Create a technique to manage yum repository
|
PR updated with a new commit |
|
still not totally functionning, as the deletion doesn't report anything nor delete the file |
|
it's because the section is not present, so nothing to remove, so nothing happens |
…e yum repository Fixes #18695: Create a technique to manage yum repository
|
PR updated with a new commit |
…o manage yum repository Fixes #18695: Create a technique to manage yum repository
|
PR updated with a new commit |
|
ready for review |
…nique to manage yum repository Fixes #18695: Create a technique to manage yum repository
|
PR updated with a new commit |
|
this one too, is it still valid ? |
https://issues.rudder.io/issues/18695