Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #21019: Better reporting using block and id for system update technique #1762

Conversation

VinceMacBuche
Copy link
Member

if => or( and("update", not("must_run_system_update")),
"NA update" usebundle => _rudder_report_state("system-update", "${na_message}", "result_na"),
if => or( not("update"),
and("update", not("must_run_system_update")),
and("update",
"must_run_system_update",
"flag_set",
not(canonify("command_execution_once_${update_command}_reached")))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one is redundant, as if flag_set, the command will never be executed

@VinceMacBuche
Copy link
Member Author

Commit modified

@VinceMacBuche VinceMacBuche force-pushed the bug_21019/better_reporting_using_block_and_id_for_system_update_technique branch from 389a60c to beefad3 Compare April 22, 2022 14:37
@VinceMacBuche
Copy link
Member Author

Commit modified

@VinceMacBuche VinceMacBuche force-pushed the bug_21019/better_reporting_using_block_and_id_for_system_update_technique branch from beefad3 to d914a67 Compare April 22, 2022 15:05
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit d914a67 into Normation:branches/rudder/7.1 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants