Fixes 4052: Adjust the distributePolicy to tolerate Relay servers #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase! |
| @@ -70,7 +72,7 @@ bundle agent generic_alive_check(app) | |||
|
|
|||
There was a problem hiding this comment.
Looks like the methods: promise just above this will be called for jetty... Shouldn't be on relay servers.
|
Looks good but I've left a lot of comments that need addressing! :) |
|
Rebased and updated ! |
| "@@DistributePolicy@@result_error@@&TRACKINGKEY&@@Check configuration-repository GIT lock@@None@@${g.execRun}##${g.uuid}@#TheEMERGENCY: THE ${g.rudder_var}/configuration-repository GIT LOCK FILE IS OLDER THAN 5 MINUTES AND COULD NOT BE DELETED. THIS ORCHESTRATOR WILL *NOT* OPERATE CORRECTLY."; | ||
|
|
||
| policy_server.!root_server:: | ||
| "@@DistributePolicy@@result_success@@&TRACKINGKEY&@@Check configuration-repository folder@@None@@${g.execRun}##${g.uuid}@#Nothing to check on a policy server that is not the root policy server"; |
There was a problem hiding this comment.
You also need a "dummy" success report here for the "Check configuration-repository GIT lock" component.
|
Ok to merge except the commit name which is missing the #. Please fix and merge. |
|
Let's go ! |
Kegeruneku
pushed a commit
that referenced
this pull request
Oct 15, 2013
…ributepolicies_for_relay_servers Fixes 4052: Adjust the distributePolicy to tolerate Relay servers
amousset
pushed a commit
to amousset/rudder-techniques
that referenced
this pull request
Dec 8, 2015
…file Fixes #4326: add missing script in build root
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIcket: http://www.rudder-project.org/redmine/issues/4052
To be merged in master