Fixes #4622: Change logrotate logic to be more clean (use of templates) #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| classes => classes_generic("rudder_logrotate_legacy_removed"), | ||
| comment => "Remove legacy logrotate files"; | ||
|
|
||
| linux:: |
There was a problem hiding this comment.
What is this linux:: class about!? We don't ever use that kind of narrow-minded restriction anymore! Do you mean "!windows::"? Or some other condition? Maybe just "any::"?
|
This is looking to be a great simplification! Nice work, @Kegeruneku! I've made a few comments inline. Also, you'll need to apply these same changes to the initial-promises (there is an automated test there actually, please ensure that when you run |
|
Superseded by #324 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: http://www.rudder-project.org/redmine/issues/4622
To be merged in master