Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4622: Change logrotate logic to be more clean (use of templates) #322

Conversation

Kegeruneku
Copy link

Ticket: http://www.rudder-project.org/redmine/issues/4622

To be merged in master

classes => classes_generic("rudder_logrotate_legacy_removed"),
comment => "Remove legacy logrotate files";

linux::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this linux:: class about!? We don't ever use that kind of narrow-minded restriction anymore! Do you mean "!windows::"? Or some other condition? Maybe just "any::"?

@jooooooon
Copy link
Member

This is looking to be a great simplification! Nice work, @Kegeruneku!

I've made a few comments inline. Also, you'll need to apply these same changes to the initial-promises (there is an automated test there actually, please ensure that when you run scripts/check-techniques.sh all tests pass and don't need rewriting as a result of this change).

@Kegeruneku
Copy link
Author

Superseded by #324

@Kegeruneku Kegeruneku closed this May 6, 2014
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants