Fix #4746: support http or https for agent / server communication. #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedricCabessa
changed the title
|
This looks great to me! Nice idea. We can extend this in the future to make the "inventory_upload_protocol" variable configurable via the webapp, too. However, this is no longer mergeable, because other changes have happened in 2.10. Could you rebase your PR, @CedricCabessa ? |
You need to edit site.cf and site.st to change the protocol:
"inventory_upload_protocol" string => "http";
or
"inventory_upload_protocol" string => "https"
|
@jooooooon updated! |
|
This looks great, thanks again @CedricCabessa. I should have noticed this myself, but as @VinceMacBuche noted in the related ticket, this can't be merged in the 2.10 branch (we only take bug fixes and this is not one). Could you retarget to 2.11 in the next few days? We will merge it there before releasing the 2.11.0~beta1 version. |
|
replaced by #389 |
amousset
pushed a commit
to amousset/rudder-techniques
that referenced
this pull request
Dec 8, 2015
…eate_rudder_node_package Fixes #4910: Create rudder-agent-thin
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You need to edit site.cf and site.st to change the protocol:
"inventory_upload_protocol" string => "http";
or
"inventory_upload_protocol" string => "https";