Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5146 - Use localhost as default policy_server to prevent error messages without policy_server.dat file #442

Merged
merged 1 commit into from
Aug 14, 2014
Merged

Fixes #5146 - Use localhost as default policy_server to prevent error messages without policy_server.dat file #442

merged 1 commit into from
Aug 14, 2014

Conversation

nperron
Copy link
Contributor

@nperron nperron commented Jul 9, 2014

Fixes #5146 - Use localhost as default policy_server to prevent error messages without policy_server.dat file

cf http://www.rudder-project.org/redmine/issues/5146

@nperron
Copy link
Contributor Author

nperron commented Jul 9, 2014

Oops, initial promises are missing

@nperron
Copy link
Contributor Author

nperron commented Jul 9, 2014

Oops, initial promises are missing

Done

@jooooooon
Copy link
Member

First things first: please don't use IP addresses, use "localhost".

@nperron
Copy link
Contributor Author

nperron commented Jul 10, 2014

First things first: please don't use IP addresses, use "localhost".

I thought that 'localhost' was forbidden but I was wrong.

@nperron
Copy link
Contributor Author

nperron commented Jul 10, 2014

You ask me to cancel this PR in order to have a abortclass if policy_server.dat is absent just after a message to warn user of the issue.
The problem is that the error is displayed by cf-serverd, not cf-agent and no abortclass can be done for cf-serverd.
In fact two issues in one:

  • cf-serverd will display 3 times an error message before to cancel its launch
  • each error message will wait for a timout of 30s which will slow down a boot process

This is why I made this PR: to prevent cf-serverd to fail its launch caused by an absence of policy_server.dat.

Do you still think this is not a good idea ?

@jooooooon
Copy link
Member

I understand. OK then, let's do this.

However, I think the default should be "rudder" to enable easier auto-configuration via a simple DNS record. Can you change that and then we'll merge this?

nperron pushed a commit that referenced this pull request Aug 14, 2014
…during_start_of_cf_serverd_without_policy_server_dat

Fixes #5146 - Use 'rudder' as default policy_server to prevent error messages without policy_server.dat file
@nperron nperron merged commit 0d306bd into Normation:branches/rudder/2.11 Aug 14, 2014
amousset pushed a commit to amousset/rudder-techniques that referenced this pull request Dec 8, 2015
…ion_to_2_11_on_rpm

Fixes #5223 - Fix migration of rudder-webapp to 2.11 on RPM
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants