Fixes #5200 - Fix errors with cf-promises on nodes #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -462,6 +463,7 @@ bundle agent addInformationsToInventory | |||
| edit_defaults => def_no_backup, | |||
| pathtype => "regex"; | |||
|
|
|||
| role_rudder_path_exists:: | |||
There was a problem hiding this comment.
This promise is already in the windows:: context, so this class expressoin should be windows.role_rudder_path_exists::
|
Please address my comments and self-merge |
|
Comments addressed and commits rebased |
|
hmm... maybe initial promises are missing. |
nperron
pushed a commit
that referenced
this pull request
Jul 9, 2014
…with_cf_promises Fixes #5200 - Fix errors with cf-promises on nodes
amousset
pushed a commit
to amousset/rudder-techniques
that referenced
this pull request
Dec 8, 2015
…69/migration_script Fixes #5269: Add script for group of all node without server roles
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5200 - Fix errors with cf-promises on nodes
cf http://www.rudder-project.org/redmine/issues/5200