Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5342: correct inventories on windows #458

Conversation

ncharles
Copy link
Member

@ncharles ncharles commented Aug 1, 2014

No description provided.

@@ -458,7 +451,7 @@ bundle agent sendInventory

# On windows, always use curl
windows::
"download_command_prefix" string => "\"${g.rudder_base_sbin}\curl\curl.exe\" -f -s --proxy '' --user ${g.davuser}:${g.davpw} -T";
"download_command_prefix" string => "\"${g.rudder_base_sbin}\curl.exe\" -f -s --user ${g.davuser}:${g.davpw} -T";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the --proxy '' argument?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proxy does't work on the windows version of curl :'(

@ncharles
Copy link
Member Author

ncharles commented Aug 1, 2014

PR has been updated

jooooooon added a commit that referenced this pull request Aug 1, 2014
…windows

Fixes #5342: correct inventories on windows
@jooooooon jooooooon merged commit de87721 into Normation:branches/rudder/2.10 Aug 1, 2014
amousset pushed a commit to amousset/rudder-techniques that referenced this pull request Dec 8, 2015
…te_space_in_control

Fixes #5380 - Remove whitespace in debian/contol file of rudder-agent
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants