Fixes #5589: Generate an Apache 2.4 compatible rudder-networks-24.conf f... #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| classes => kept_if_else("rudder_networks_ok", "rudder_networks_repaired","rudder_networks_failed"), | ||
| comment => "Copying rudder apache configuration"; | ||
|
|
||
| edit_line => insert_lines("${network_acl[${index}]}"), |
There was a problem hiding this comment.
We seem to have lost the "allow from 127.0.0.0/8" here...
There was a problem hiding this comment.
It is expected: this 127.0... generate duplicates in the final file, like this:
Allow from 127.0.0.0/8 <= This shouldn't be here !
Allow from ::1
Allow from 127.0.0.1
Allow from 192.168.42.0/24
Kegeruneku
force-pushed
the
ust_5183/dev/5589_generate_rudder_networks_24_conf_file
branch
from
6fc39a7
to
8d97a9c
Compare
|
PR has been updated according to feedback |
|
|
|
This looks good to me! Merging. |
jooooooon
added a commit
that referenced
this pull request
Sep 30, 2014
…dder_networks_24_conf_file Fixes #5589: Generate an Apache 2.4 compatible rudder-networks-24.conf f...
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ile
Ticket: http://www.rudder-project.org/redmine/issues/5589
To be merged in 2.11