Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8307: Use variables for path to cf-agent in system Techniques to work on Windows #927

Conversation

jooooooon
Copy link
Member

@jooooooon
Copy link
Member Author

@ncharles Could you review this please?

@@ -60,7 +60,7 @@ bundle server access_rules

any::
# Allow server to remotely run the agent
"/var/rudder/cfengine-community/bin/cf-agent"
"${sys.cf-agent}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the variable is ${sys.cf_agent} (note the underscore)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed.

@jooooooon jooooooon force-pushed the bug_8307/use_variables_for_path_to_cf_agent_in_system_techniques_to_work_on_windows branch from b345381 to 033738f Compare May 23, 2016 11:58
@jooooooon
Copy link
Member Author

PR rebased

@jooooooon jooooooon force-pushed the bug_8307/use_variables_for_path_to_cf_agent_in_system_techniques_to_work_on_windows branch from 033738f to 7266f09 Compare May 23, 2016 11:58
@jooooooon
Copy link
Member Author

Commit modified

@ncharles
Copy link
Member

merging

@ncharles ncharles merged commit 8e7517f into Normation:branches/rudder/2.11 May 23, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants