Fixes #7638: Rudder agent connect at each runs to its policy server to get its server uuid #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upmerging this into following branches will be HARD, so please DON'T merge this once the review is OK, but instead signal your approval to me, and I will manually merge and upmerge it at once. |
|
@ncharles Could you review this please? |
|
This looks ok, but why isn't the initial promises modified also ? |
|
Commit modified |
|
PR rebased |
|
Do not merge for now, this is screwed up for some reason |
…o get its server uuid
|
Commit modified |
jooooooon
force-pushed
the
bug_7638/rudder_agent_connect_at_each_runs_to_its_policy_server_to_get_its_server_uuid
branch
from
e031ae8
to
ec4ae42
Compare
|
Actually, I don't see any changes |
|
Yeah GitHub seems to be broken at the moment. Give it a few hours... |
jooooooon
force-pushed
the
bug_7638/rudder_agent_connect_at_each_runs_to_its_policy_server_to_get_its_server_uuid
branch
from
ec4ae42
to
8e7517f
Compare
|
OK, GitHub is OK again. Ready for review again @ncharles |
|
looks good |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7638