Fixes #8424: When updating runs, hooks should really be async #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: pom.xml rudder-core/pom.xml rudder-web/pom.xml
Conflicts: pom.xml rudder-core/pom.xml rudder-web/pom.xml
|
hum, we should indeed probably run a test version |
…ver marked as unresponsive
…_reports_with_a_wrong_config_id_it_is_never_marked_as_unresponsive Fixes #8118: When a node send reports with a wrong config_id it is never marked as unresponsive
…e modifications to change technique version
…th_pr' into branches/rudder/3.1
…irective_modifications_to_change_technique_version_pr' into branches/rudder/3.1
…hat the graphe is clickable
|
This PR is not mergeable to upper versions. |
fanf
force-pushed
the
bug_8424/when_updating_runs_hooks_should_really_be_async
branch
from
44338f0
to
cf15256
Compare
|
PR replaced by #1127 |
fanf
deleted the
bug_8424/when_updating_runs_hooks_should_really_be_async
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8424
So. That PR set back the future {} in hook, and I was not able to reproduce the thread problems I experienced the last time. So perhaps the problem was with the future{} in future{}, but I wasn't able to reproduce it either.
So I'm a little unconfortable with that proposed solution, but can't see a better. Perhaps it would be helpfull to build a war with the fixe (before commiting) and using it for some time to see what happen (for ex. in our labo).