Fixes #4085: Really get all machine inventories for list of node displaying #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…node displaying
|
Looks good ! |
ncharles
added a commit
that referenced
this pull request
Oct 17, 2013
…ayed_in_list_of_nodes Fixes #4085: Really get all machine inventories for list of node displaying
fanf
deleted the
bug_4085/no_machine_inventory_displayed_in_list_of_nodes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that we only requested machine inventories in the "accepted" branch. But sometimes, when nodes are accepted/removed/accepted, machine inventories end in the "deleted" branch. So we need to query all inventories.
For that to not be to costly, I restrained the returned LDAP entries' attributes to only "objectClass", since it's the only one needed to decide if the machine is virtual or not.