Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar functionality #439

Merged

Conversation

Motormary
Copy link
Contributor

  • Add search.mjs
  • Create search function
  • Search drawer functionality

There are a lot of file changes, but they are small and repeated:

  • Added script for search bar in all pages
    image

  • Edited out tailwind code "hidden" from all the search bars because of animation conflict.
    image

  • Added a couple of ID's on elements for search results hrefs.
    image

I added a placeholder for search results, only in index.html as an example on how the search function could be used.
image

The "search.mjs" contains about 150 lines of placeholder content. Lines 0-94 and from 189+

@Motormary Motormary requested a review from a team April 11, 2024 21:01
@Motormary Motormary linked an issue Apr 11, 2024 that may be closed by this pull request
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for dazzling-melomakarona-fe8d9f ready!

Name Link
🔨 Latest commit e4f83ee
🔍 Latest deploy log https://app.netlify.com/sites/dazzling-melomakarona-fe8d9f/deploys/6618f01d21210c0008fff6c7
😎 Deploy Preview https://deploy-preview-439--dazzling-melomakarona-fe8d9f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for snazzy-moonbeam-86e465 ready!

Name Link
🔨 Latest commit e4f83ee
🔍 Latest deploy log https://app.netlify.com/sites/snazzy-moonbeam-86e465/deploys/6618f01d23bd4800082d5644
😎 Deploy Preview https://deploy-preview-439--snazzy-moonbeam-86e465.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Motormary Motormary changed the title Animated search bar working + search function + placeholder search results in index.html Search bar functionality Apr 11, 2024
@lem31 lem31 requested a review from Whisperpiano April 12, 2024 07:13
Copy link
Contributor

@Whisperpiano Whisperpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I dont see any mistake here, merging

@Whisperpiano Whisperpiano merged commit 9436241 into main Apr 12, 2024
8 checks passed
@Whisperpiano Whisperpiano deleted the 416-create-search-function-for-website---in-nav-menu branch April 12, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create search functionality - (in nav menu)
2 participants