Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/5.4.2 #762

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Hotfix/5.4.2 #762

merged 2 commits into from
Jan 14, 2022

Conversation

olsi-qose
Copy link
Member

Description

Our module is building the currency formatting for all active currencies. In case the merchant has many currencies enabled for the store, this can turn into an expensive operation as currencies are read from the filesystem.

Related Issue

Motivation and Context

How Has This Been Tested?

Documentation:

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@olsi-qose olsi-qose self-assigned this Jan 14, 2022
@olsi-qose olsi-qose merged commit 56cb5d4 into master Jan 14, 2022
@olsi-qose olsi-qose deleted the hotfix/5.4.2 branch January 14, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dairbuirabass dairbuirabass dairbuirabass approved these changes

Assignees

@olsi-qose olsi-qose

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olsi-qose @dairbuirabass