-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove queue processor indexer. Product indexer now only send product id's straight to message queue #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
supercid
changed the title
Remove second indexer. Nosto indexer now only sends product id's to message queue
Remove second indexer. Product indexer now only send product id's straight to message queue
Nov 2, 2022
supercid
changed the title
Remove second indexer. Product indexer now only send product id's straight to message queue
Remove queue processor indexer. Product indexer now only send product id's straight to message queue
Nov 2, 2022
supercid
requested review from
dairbuirabass and
olsi-qose
and removed request for
dairbuirabass
November 7, 2022 09:48
dairbuirabass
approved these changes
Nov 7, 2022
Couldn't spot anything! One thing that comes to mind - to test with MSI module? Just in case. |
@dairbuirabass It's already tested and you can check on https://magento245.plugintest.nos.to/?nostodebug=true once my benchmark is completed |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes unnecessary secondary indexer, which does extra processing and brings no real benefit.
With this PR, there will be a single indexer, which simply send product ID's to the message queue with an action to either update or delete products that will be consumed by SyncService
Related Issue
How Has This Been Tested?
Things to test:
Documentation:
Checklist: