Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove queue processor indexer. Product indexer now only send product id's straight to message queue #805

Merged
merged 11 commits into from
Nov 7, 2022

Conversation

supercid
Copy link
Member

@supercid supercid commented Nov 1, 2022

Description

Removes unnecessary secondary indexer, which does extra processing and brings no real benefit.
With this PR, there will be a single indexer, which simply send product ID's to the message queue with an action to either update or delete products that will be consumed by SyncService

Related Issue

How Has This Been Tested?

Things to test:

Documentation:

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@supercid supercid changed the title Remove second indexer. Nosto indexer now only sends product id's to message queue Remove second indexer. Product indexer now only send product id's straight to message queue Nov 2, 2022
@supercid supercid changed the title Remove second indexer. Product indexer now only send product id's straight to message queue Remove queue processor indexer. Product indexer now only send product id's straight to message queue Nov 2, 2022
@supercid supercid added this to the 7.0.0 milestone Nov 2, 2022
@supercid supercid self-assigned this Nov 2, 2022
@supercid supercid requested review from dairbuirabass and olsi-qose and removed request for dairbuirabass November 7, 2022 09:48
@dairbuirabass
Copy link
Contributor

Couldn't spot anything! One thing that comes to mind - to test with MSI module? Just in case.

@supercid
Copy link
Member Author

supercid commented Nov 7, 2022

@dairbuirabass It's already tested and you can check on https://magento245.plugintest.nos.to/?nostodebug=true once my benchmark is completed

@supercid supercid merged commit d4734aa into develop Nov 7, 2022
@supercid supercid deleted the feature/remove-second-indexer branch November 7, 2022 12:44
@supercid supercid mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants