Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save config input for later use #798

Merged
merged 6 commits into from
Aug 3, 2024
Merged

Save config input for later use #798

merged 6 commits into from
Aug 3, 2024

Conversation

davidnewhall
Copy link
Contributor

@davidnewhall davidnewhall commented Aug 3, 2024

Code refactor around how config data is stored. We now store a copy of the original config before modifying it with validators and filepath parsers. This allows us to determine if the HostID is saved or not.

  • Stores copy of input config internally.
  • Applies this new data copy to UI 'string' input elements on config UI page.
  • Applies home dir (~) support to filepath: inputs.
  • Prints filepath input files and variable names on start/reload.
  • Save button now appears in UI when host ID is not saved.
  • Closes add hidden uuid input so save button appears in webui #796

@davidnewhall davidnewhall merged commit 8e3cd73 into main Aug 3, 2024
16 checks passed
@davidnewhall davidnewhall deleted the dn2_hostid branch August 3, 2024 21:54
truecharts-admin referenced this pull request in truecharts/public Sep 24, 2024
…9 by renovate (#26792)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [golift/notifiarr](https://redirect.github.com/Notifiarr/notifiarr) |
patch | `0.8.1` -> `0.8.2` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>Notifiarr/notifiarr (golift/notifiarr)</summary>

###
[`v0.8.2`](https://redirect.github.com/Notifiarr/notifiarr/releases/tag/v0.8.2):
Notifiarr v0.8.2

[Compare
Source](https://redirect.github.com/Notifiarr/notifiarr/compare/v0.8.1...v0.8.2)

#### Features

- Variable values may now be read from additional config files using
`filepath:`
-   Adds HA stats to Synology snapshots.
-   HTTP assets are stored compressed.
-   HTTP responses are now served compressed.
-   Builds an Arch Linux package now.

#### Bugs

- Sonarr broke the API. This provides a fix to make TRaSH sync work
again.
-   Intermittent crash in `GetAllLogPaths` is now fixed.

#### Auto Generated Notes

- Converts bindata usage to embed usage, gzip all http responses. by
[@&#8203;davidnewhall](https://redirect.github.com/davidnewhall) in
[https://github.com/Notifiarr/notifiarr/pull/775](https://redirect.github.com/Notifiarr/notifiarr/pull/775)
- fix github updater by
[@&#8203;davidnewhall](https://redirect.github.com/davidnewhall) in
[https://github.com/Notifiarr/notifiarr/pull/792](https://redirect.github.com/Notifiarr/notifiarr/pull/792)
- Arch package builder by
[@&#8203;davidnewhall](https://redirect.github.com/davidnewhall) in
[https://github.com/Notifiarr/notifiarr/pull/794](https://redirect.github.com/Notifiarr/notifiarr/pull/794)
- Update module github.com/shirou/gopsutil/v4 to v4.24.7 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/Notifiarr/notifiarr/pull/797](https://redirect.github.com/Notifiarr/notifiarr/pull/797)
- Save config input for later use by
[@&#8203;davidnewhall](https://redirect.github.com/davidnewhall) in
[https://github.com/Notifiarr/notifiarr/pull/798](https://redirect.github.com/Notifiarr/notifiarr/pull/798)
- remove all the whitespace by
[@&#8203;davidnewhall](https://redirect.github.com/davidnewhall) in
[https://github.com/Notifiarr/notifiarr/pull/799](https://redirect.github.com/Notifiarr/notifiarr/pull/799)
- Shorten a bunch of html lines. by
[@&#8203;davidnewhall](https://redirect.github.com/davidnewhall) in
[https://github.com/Notifiarr/notifiarr/pull/800](https://redirect.github.com/Notifiarr/notifiarr/pull/800)
- last of the pieces to make filepath inputs work everywhere. by
[@&#8203;davidnewhall](https://redirect.github.com/davidnewhall) in
[https://github.com/Notifiarr/notifiarr/pull/801](https://redirect.github.com/Notifiarr/notifiarr/pull/801)
- update deps, bug fix by
[@&#8203;davidnewhall](https://redirect.github.com/davidnewhall) in
[https://github.com/Notifiarr/notifiarr/pull/823](https://redirect.github.com/Notifiarr/notifiarr/pull/823)

**Full Changelog**:
Notifiarr/notifiarr@v0.8.1...v0.8.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45NC4yIiwidXBkYXRlZEluVmVyIjoiMzguOTQuMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJhdXRvbWVyZ2UiLCJ1cGRhdGUvZG9ja2VyL2dlbmVyYWwvbm9uLW1ham9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add hidden uuid input so save button appears in webui
1 participant