Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block equation display issue #491

Closed
wants to merge 4 commits into from
Closed

Conversation

drjackchan
Copy link

Description

The inline variable is hardcoded to false at the moment, making all the equations rendered to be inline equations. Fixing this issue by removing the hardcoding.

Notion Test Page ID

39a20e59ea4147f1b3e145166528ab95

@vercel
Copy link

vercel bot commented May 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-notion-x ❌ Failed (Inspect) Jun 7, 2023 0:45am
react-notion-x-minimal-demo ❌ Failed (Inspect) Jun 7, 2023 0:45am

@jacksongoode
Copy link

Is this not addressed in #281?

@drjackchan
Copy link
Author

I looked at change #281 , it seems to me that it is hardcoding the display mode != inline? How can that differentiate inline and block equation?

@transitive-bullshit
Copy link
Member

I included the core of the fix for block but there are other changes in this PR that are unrelated, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants