this fixes gorhill#212

Noxgrim · May 17, 2015 · b828e99 · b828e99
1 parent 1e61180
commit b828e99
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/src/_locales/en/messages.json b/src/_locales/en/messages.json
@@ -587,6 +587,10 @@
         "message": "filter expression(s)",
         "description": "Appears in the input filed where filter expressions are entered"
     },
+    "loggerMaxEntriesTip" : {
+        "message": "Maximum number of entries",
+        "description": "Appears as a tooltip when hovering the input field"
+    },
     "loggerEntryUserAgentSpoofing" : {
         "message": "spoofing user agent with: {{value}}",
         "description": "An entry for when a new user agent string is selected"

diff --git a/src/js/i18n.js b/src/js/i18n.js
@@ -30,6 +30,8 @@
 
 /******************************************************************************/
 
+var text;
+
 var nodeList = document.querySelectorAll('[data-i18n]');
 var i = nodeList.length;
 var node;
@@ -51,6 +53,13 @@ while ( i-- ) {
     node = nodeList[i];
     node.setAttribute('data-tip', vAPI.i18n(node.getAttribute('data-i18n-tip')));
 }
+nodeList = document.querySelectorAll('[title]');
+i = nodeList.length;
+while ( i-- ) {
+    node = nodeList[i];
+    text = node.getAttribute('title');
+    node.setAttribute('title', vAPI.i18n(text) || text);
+}
 
 nodeList = document.querySelectorAll('input[placeholder]');
 i = nodeList.length;

diff --git a/src/logger-ui.html b/src/logger-ui.html
@@ -21,7 +21,7 @@
         <span id="clean" class="button fa disabled">&#xf00d;</span>
         <span id="clear" class="button fa disabled">&#xf12d;</span>
         <span id="filterButton" class="button fa">&#xf0b0;</span><input id="filterInput" type="text" placeholder="loggerFilterInputPlaceholder">
-        <input id="maxEntries" type="text" size="5" title="logMaxEntriesTip">
+        <input id="maxEntries" type="text" size="5" title="loggerMaxEntriesTip">
         </div>
     </div>