Unexpected error “Your project file doesn’t list ‘win’ as a “RuntimeIdentifier”” occurs when building the solution after enabling “RestoreLockedMode”

[v-crchang]

Details about Problem

NuGet version: NuGet Client Dev\5.10.0.7140
VS Version: Main\31021.18
OS Version: Windows-10-Enterprise-20h1

Repro steps and/or sample project

1. Create a C# Class Library (.NET Framework) project via VS.
2. Install a few ‘PackageReference’ packages into the projects.
3. Set MSBuild property “RestorePackagesWithLockFile” to true in csproj file.
   <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
4. Do a restore.
5. Check it should have generated ‘packages.lock.json’ file alongside *.csproj file.
6. Set msbuild property “RestoreLockedMode” to “true”.
   <RestoreLockedMode>true</RestoreLockedMode>
7. Install another package.
8. It should still work fine and update ‘packages.lock.json’ file.
9. Manually add a new PackageReference item into csproj file.

<PackageReference Include="NUnit">
      <Version>3.12.0</Version>
    </PackageReference>

10. Perform restore.
11. Build the solution.

Expected

Only expected error NU1004 shows on error list when building the solution.

Actual

Unexpected error “Your project file doesn’t list ‘win’ as a “RuntimeIdentifier”” occurs when building the solution as below screenshot.

Notes

1. This issue doesn’t repro on .NET Core projects.
2. The issue starts from Dev\5.9.0.7086.

[aortiz-msft]

@nkolev92 - Would you mind taking a look?

[nkolev92]

Only expected error NU1004 shows on error list when building the solution.

I'm not confident this we can rely on this as an assumption.
This is invalid restore scenario, so what other components do post restore is not fully in our control.

If you had actual code in any of your projects, then at build time, you'd get many other other errors telling you that it can't resolve certain types.

There's a chance we can avoid this particular message. We create dummy targets. I'll take a look during Quality Week.
I think the pri 2 label makes sense for now.

[kartheekp-ms]

I found this issue while working on a VS feedback ticket with similar error message https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1348331.

I followed the repro steps mentioned in the issue description on Dev17 and noticed only 1 error NU1004 in the error list window.

[nkolev92]

SDK based proejcts won't have this issue since the defaults are different.

[michal-ciechan]

Is there a workaround for this? Getting this all of a sudden since upgrading to .NET 7 when trying to build an old style .csproj (which used to build fine, and is building fine on build server which doesn't have .NET 7 or related tools)

Microsoft.NuGet.targets(198, 5): Your project file doesn't list 'win' as a "RuntimeIdentifier". You should add 'win' to the "RuntimeIdentifiers" property in your project file and then re-run NuGet restore.

Edit: Updating my Visual Studio 22 to latest version, restart + loading the project has fixed it (and it asked to download .NET Desktop Development tools)

[k0zi]

Clean the project (delete obj and bin directory) and build it again.

[trivalik]

This could happen in case you upgrade a project to new SDK Project style, but then later you checkout a old commit with old project type and then it is required to delete obj/bin folder like @k0zi already stated. In my case it was important to close Visual Studio during deleting.