Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using EmbedInteropTypes for NuGet's VS extenbility packages/assemblies #10892

Closed
zivkan opened this issue May 24, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4072
Closed

Stop using EmbedInteropTypes for NuGet's VS extenbility packages/assemblies #10892

zivkan opened this issue May 24, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4072
Assignees
@zivkan
Labels
Functionality:SDK The NuGet client packages published to nuget.org Product:VS.Client Type:DCR Design Change Request
Milestone
Sprint 2021-06

Comments

@zivkan
Copy link
Member

zivkan commented May 24, 2021

The VS SDK for dev17 (VS 2022) has stopped using EmbedInteropTypes. One of their primary reasons is that is makes sharing components with VS for Mac problematic. This might not really be an issue for us, since we (NuGet client team) don't work on VS for Mac in any way, so our VS APIs might not be in VS for Mac. But it would be good to align with design choices for VS, plus some VS (on windows) internal teams have reported issues to me which binding redirects would solve.
@zivkan zivkan added Product:VS.Client Functionality:SDK The NuGet client packages published to nuget.org Type:DCR Design Change Request labels May 24, 2021
@zivkan zivkan added this to the Sprint 2021-05 milestone May 24, 2021
@zivkan zivkan self-assigned this May 24, 2021
@zivkan zivkan mentioned this issue May 24, 2021
Merged
8 tasks
@zivkan zivkan modified the milestones: Sprint 2021-05, Sprint 2021-06 Jun 7, 2021
@zivkan zivkan changed the title NuGet.VisualStudio should stop setting EmbedInteropTypes Stop using EmbedInteropTypes for NuGet's VS extenbility packages/assemblies Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zivkan zivkan

Labels
Functionality:SDK The NuGet client packages published to nuget.org Product:VS.Client Type:DCR Design Change Request
Projects
None yet
Milestone
Sprint 2021-06
Development

Successfully merging a pull request may close this issue.

NuGet.VisualStudio no longer uses EmbedInteropTypes NuGet/NuGet.Client
1 participant
@zivkan