-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: $(IsPackable)
is not quoted
#11025
Comments
$(IsPackable)
is not quoted
Hi, I'm not sure if my understanding is correct. Pls correct me is there is any misunderstanding. Thanks! So the quotation marks do not affect the correctness of the evaluation results. You may try the following to confirm that:
|
Yes, I know that this issue will not affect the result. The rule of writing is that when comparing variables such as |
Hi @aetos382 , thanks for the clarification! To summarize, the code in this line should be changed from: Although it doesn't affect the results of evaluation, it makes the log show the following: |
I would like to take this issue. Please assign this to me. 🙂 |
PR submitted: NuGet/NuGet.Client#4159 |
NuGet Product Used
dotnet.exe
Product Version
5.0.302
Worked before?
yes
Impact
It bothers me. A fix would be nice
Repro Steps & Context
Create a project file as shown below, and run
dotnet pack -v d
in the directory where this file is located.This will output the following to the log.
This is because
$(IsPackable)
is not enclosed in quotation marks in the following places.https://github.com/NuGet/NuGet.Client/blob/680f9bd4e97db7cd7482584276886764de69d3cb/src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.targets#L213
This should look something like this.
Verbose Logs
The text was updated successfully, but these errors were encountered: