Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Package namespaces for packages.config scenarios is using all the sources as fallback option when no matching namespaces are found for a package #11170

Closed
kartheekp-ms opened this issue Aug 20, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4212
Assignees
Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Functionality:Restore Priority:1 High priority issues that must be resolved in the current sprint. Product:NuGet.exe NuGet.exe Type:Bug

Comments

@kartheekp-ms
Copy link
Contributor

kartheekp-ms commented Aug 20, 2021

NuGet Product Used

MSBuild.exe, NuGet.exe, Visual Studio Package Management UI, Visual Studio Package Manager Console

Product Version

nuget.exe

Worked before?

No response

Impact

Other

Repro Steps & Context

The following test should have failed because "测试更新包" package has no namespace defined. When I ran the test locally the said package was restored successfully which should not be the case.

https://github.com/NuGet/NuGet.Client/blob/c1a0597e5498bcf3bf0938b3dd0170edbf0b2d20/test/NuGet.Clients.Tests/NuGet.CommandLine.Test/NuGetRestoreCommandTest.cs#L2664

Verbose Logs

No response

@kartheekp-ms kartheekp-ms added Priority:1 High priority issues that must be resolved in the current sprint. Type:Bug Product:NuGet.exe NuGet.exe Functionality:Restore Area:PackageSourceMapping Issues related to the package source mapping feature Triage:Untriaged labels Aug 20, 2021
@kartheekp-ms kartheekp-ms added this to the Sprint 2021-08 milestone Aug 20, 2021
@erdembayar erdembayar self-assigned this Aug 20, 2021
@erdembayar erdembayar changed the title [Bug]: Package namespaces for packages.config scenarios is using all the sources as fallback option when no matching namespaces are found for a package [Bug]: Change from permissive mode to fullySpecified mode for PC project package namespace Aug 20, 2021
@erdembayar erdembayar added Priority:2 Issues for the current backlog. and removed Priority:1 High priority issues that must be resolved in the current sprint. labels Aug 20, 2021
@erdembayar erdembayar changed the title [Bug]: Change from permissive mode to fullySpecified mode for PC project package namespace [Bug]: Package namespaces for packages.config scenarios is using all the sources as fallback option when no matching namespaces are found for a package Aug 20, 2021
@erdembayar erdembayar added Priority:1 High priority issues that must be resolved in the current sprint. and removed Priority:2 Issues for the current backlog. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Functionality:Restore Priority:1 High priority issues that must be resolved in the current sprint. Product:NuGet.exe NuGet.exe Type:Bug
Projects
None yet
3 participants