Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Telemetry event missing in Visual Studio #11206

Closed
jeffkl opened this issue Aug 31, 2021 · 2 comments · Fixed by NuGet/NuGet.Client#4233
Closed

[Bug]: Telemetry event missing in Visual Studio #11206

jeffkl opened this issue Aug 31, 2021 · 2 comments · Fixed by NuGet/NuGet.Client#4233
Assignees
Labels
Area:Logging Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Type:Bug

Comments

@jeffkl
Copy link
Contributor

jeffkl commented Aug 31, 2021

NuGet Product Used

Visual Studio Package Management UI

Product Version

6.0

Worked before?

No

Impact

Other

Repro Steps & Context

  1. Load solution with a CPS-based project
  2. Allow background restore to run

Expected

restoreinformation telemetry event is fired

Actual

Telemetry service in Visual Studio is not yet initialized when the telemetry event is fired, so the information is not sent.

The telemetry service is created in two places:

https://github.com/NuGet/NuGet.Client/blob/543d419b002c33b2f63740b47e62db137d80d2b3/src/NuGet.Clients/NuGet.Tools/NuGetPackage.cs#L158

https://github.com/NuGet/NuGet.Client/blob/543d419b002c33b2f63740b47e62db137d80d2b3/src/NuGet.Clients/NuGet.VisualStudio.OnlineEnvironment.Client/NuGetClientPackage.cs#L53

But is missing from RestoreManagerPackage:
https://github.com/NuGet/NuGet.Client/blob/543d419b002c33b2f63740b47e62db137d80d2b3/src/NuGet.Clients/NuGet.SolutionRestoreManager/RestoreManagerPackage.cs#L42

Verbose Logs

No response

@jeffkl jeffkl added Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Type:Bug Area:Logging labels Aug 31, 2021
@jeffkl jeffkl added this to the Sprint 2021-08 milestone Aug 31, 2021
@jeffkl jeffkl self-assigned this Aug 31, 2021
@jeffkl
Copy link
Contributor Author

jeffkl commented Aug 31, 2021

@zkat can you review that I've added the correct tags, milestone, etc to this issue?

@zkat
Copy link
Contributor

zkat commented Aug 31, 2021

This looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Logging Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants