Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ArPow build doesn't work well when in a subdirectory of an unrelated git repository #11227

Closed
omajid opened this issue Sep 9, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4254
Labels
Community PRs (and linked Issues) created by someone not in the NuGet team help wanted Considered good issues for community contributions. Triage:Investigate Type:Bug

Comments

@omajid
Copy link

omajid commented Sep 9, 2021

NuGet Product Used

dotnet.exe

Product Version

6eafa5f12562510adf3dae0c649d4b5f955ef6f8

Worked before?

No; this is new with ArPow

Impact

I'm unable to use this version

Repro Steps & Context

NuGet.Client has patches that rename NuGet.Config to NuGet.config: https://github.com/NuGet/NuGet.Client/blob/dev/eng/source-build-patches/0001-Rename-NuGet.Config-to-NuGet.config-to-account-for-a.patch. This was added with NuGet/NuGet.Client@55e6392

That patch is applied with git apply. That doesn't work when the .git is removed/missing and there the sources just happen to be located (deep) within an unrelated git repository tree. See dotnet/source-build#2445 for the details on source-build side

Here are the steps I used to run into this issue

  1. git clone https://pagure.io/dotnet-sig/dotnet6.0.git
  2. cd dotnet6.0
  3. ./build-dotnet-tarball --bootstrap 1afc0b6892dcd718cd88e281f3acd840cb966a4d # commit sha from installer repo
  4. tar xf dotnet-1afc0b6892dcd718cd88e281f3acd840cb966a4d-x64-bootstrap.tar.gz
  5. cd dotnet-1afc0b6892dcd718cd88e281f3acd840cb966a4d-x64-bootstrap
  6. ./prep.sh
  7. ./build.sh --online

Build fails, saying that NuGet.config is not found even though 0001-Rename-NuGet.Config-to-NuGet.config-to-account-for-a.patch should have fixed that.

Verbose Logs

No response

@zkat zkat added Community PRs (and linked Issues) created by someone not in the NuGet team help wanted Considered good issues for community contributions. Triage:Investigate and removed Triage:Untriaged labels Sep 9, 2021
@zkat zkat added this to the Sprint 2021-09 milestone Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PRs (and linked Issues) created by someone not in the NuGet team help wanted Considered good issues for community contributions. Triage:Investigate Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants