[Bug]: All the checked sources will be unchecked after pressing Up/Down button in Options dialog

[v-luzh]

NuGet Product Used

Visual Studio Package Management UI

Product Version

Release-5.11.x\5.11.1.15

Worked before?

No response

Impact

It bothers me. A fix would be nice

Repro Steps & Context

Details about Problem

VS Version: D16.11\32208.345
NuGet Version: Release-5.11.x\5.11.1.15
OS Version: Windows-11-Enterprise-21H2

Repro steps

1. Launch VS and create a C# Console Application (.NET Core 6.0) project.
2. Open PM UI, click the Settings button and go to Options->NuGet Package Manager->Package Sources.
3. Make sure some sources has already been checked.
4. Select any package source in the list and press Up/Down button.

Expected

The checked status will not be changed.

Actual

All the checked sources will be unchecked as below screenshot.

Notes

1.It doesn’t happen on + and X button.
2.It doesn’t repro on 17.1 Preview6 and 17.2 Preview1.

Verbose Logs

No response

[zivkan]

@v-luzh I cherry-picked this fix onto the release-5.11.x branch: NuGet/NuGet.Client#4376

Can you please test again? From my own testing the add and remove buttons don't clear the checkboxes, and with the arrows gone, this issue should no longer be a problem.

[v-luzh]

Hi @zivkan This bug reproes on arrows buttons on D16.11\32208.345 + NuGet Client Release-5.11.x\5.11.1.15 as below, doesn't repro on add and remove buttons.

The arrows buttons are gone on 17.2 Preview1, but they are still existing on 16.11 servicing. So we think it should be fix on 16.11.

[zivkan]

@v-luzh The up and down arrows should have been removed in 5.11.1.16. Can you please validate with the latest build from
release-5.11.x?

Commits: https://github.com/NuGet/NuGet.Client/commits/release-5.11.x
The one that removed up/down arrow: NuGet/NuGet.Client@48ae5a5

[v-luzh]

@zivkan Yes, this bug is fixed on D16.11\32208.345 + NuGet Client Release-5.11.x\5.11.1.17 after verifying.