Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling CreateLockFileTargetLibrary twice when AssetTargetFallback is used #11654

Closed
nkolev92 opened this issue Mar 7, 2022 · 0 comments · Fixed by NuGet/NuGet.Client#4771
Closed

Avoid calling CreateLockFileTargetLibrary twice when AssetTargetFallback is used #11654

nkolev92 opened this issue Mar 7, 2022 · 0 comments · Fixed by NuGet/NuGet.Client#4771
Assignees
@nkolev92
Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Restore Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug
Milestone
6.4

Comments

@nkolev92
Copy link
Member

nkolev92 commented Mar 7, 2022 •
edited
Loading

See: https://github.com/NuGet/NuGet.Client/blob/52dd383ae0899680f487ff31e9dd63d0033eea32/src/NuGet.Core/NuGet.Commands/RestoreCommand/LockFileBuilder.cs#L247
@nkolev92 nkolev92 added Priority:2 Issues for the current backlog. Type:Bug Tenet:Performance Performance issues Functionality:Restore labels Mar 7, 2022
@nkolev92 nkolev92 added this to the Sprint 2022-04 milestone Mar 7, 2022
@nkolev92 nkolev92 self-assigned this Mar 7, 2022
@nkolev92 nkolev92 added the Category:Quality Week Issues that should be considered for quality week label Apr 4, 2022
@nkolev92 nkolev92 removed this from the Sprint 2022-04 milestone May 3, 2022
@nkolev92 nkolev92 mentioned this issue Aug 26, 2022
Merged
8 tasks
@jebriede jebriede added this to the 6.4 milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Restore Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug
Projects
None yet
Milestone
6.4
3 participants
@nkolev92 @jebriede @heng-liu