Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DCR]: Central package management package source mapping should only look at configured feeds #11951

Closed
jeffkl opened this issue Jul 7, 2022 · 1 comment · Fixed by NuGet/NuGet.Client#4764
Closed

[DCR]: Central package management package source mapping should only look at configured feeds #11951

jeffkl opened this issue Jul 7, 2022 · 1 comment · Fixed by NuGet/NuGet.Client#4764
Assignees
@jeffkl
Labels
Area:RestoreCPM Central package management Priority:1 High priority issues that must be resolved in the current sprint. Type:DCR Design Change Request
Milestone
6.4

Comments

@jeffkl
Copy link
Contributor

jeffkl commented Jul 7, 2022

NuGet Product(s) Affected

MSBuild.exe

Current Behavior

Currently CPM looks at all of the feeds that took part of restore. However, the .NET SDK injects local sources which makes CPM think that too many sources are in use and emits a warning about needing to use package source mapping. The tooling (nuget.exe and dotnet nuget) do not show these sources so it is confusing

Desired Behavior

The package source mapping verification in CPM should only take into account sources that are compatible with package source mapping.

Additional Context

No response
@jeffkl jeffkl added Priority:1 High priority issues that must be resolved in the current sprint. Type:DCR Design Change Request Area:RestoreCPM Central package management Pipeline:Backlog labels Jul 7, 2022
@jeffkl jeffkl self-assigned this Jul 7, 2022
@jeffkl jeffkl mentioned this issue Jul 7, 2022
Closed
21 tasks
@jeffkl
Copy link
Contributor Author

jeffkl commented Aug 10, 2022

Related to #11822

@jeffkl jeffkl mentioned this issue Aug 11, 2022
Open
@jeffkl jeffkl mentioned this issue Aug 19, 2022
Merged
8 tasks
This was referenced Oct 19, 2022
Closed
Open
@jebriede jebriede added this to the 6.4 milestone Oct 27, 2022
@baronfel baronfel mentioned this issue Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffkl jeffkl

Labels
Area:RestoreCPM Central package management Priority:1 High priority issues that must be resolved in the current sprint. Type:DCR Design Change Request
Projects
None yet
Milestone
6.4
3 participants
@nkolev92 @jebriede @jeffkl