[DCR]: Adding a new Package Source in VS Options should be immediately available for a Package Source Mapping

[donnie-msft]

NuGet Product(s) Affected

Visual Studio Package Management UI

Current Behavior

As described in discussion on the PR creating a new Package Source Mappings page in VS Options,
NuGet/NuGet.Client#4847 (comment), Package Sources do not commit immediately to a config file. Therefore, a newly added source cannot be immediately used in a mapping, today.

Desired Behavior

A user should be able to add a new source and immediately create a Package Source Mapping for it, without having to press OK and re-open the options.

Additional Context

No response

[donnie-msft]

#11361

[zivkan]

Is this still an issue since #1538 was implemented?

[donnie-msft]

Is this still an issue since #1538 was implemented?

1538 is for PM UI and 12155 is for the Options dialog. What do you think?

[zivkan]

This issue says that when some setting is changed, customers have to close and reopen the solution. The implementation for #1538 uses a file watcher on the singleton settings, so regardless of what caused the nuget.config file to change, VS should immediately reload the files and therefore any changes should apply to any NuGet VS component that uses that singleton settings instance. Therefore, I would expect that the behaviour described in this issue no longer occurs.

[donnie-msft]

This issue says that when some setting is changed, customers have to close and reopen the solution.

Not the solution, just the Options dialog.

[donnie-msft]

I just tested it to make sure I'm not missing something: Options still doesn't pick up a newly added package source. Just to reiterate: This is about the Options dialog, not the PM UI, and the file watcher won't affect the behavior there. Options loads sources from disk once, then writes them after pressing "OK" on the dialog.

[donnie-msft]

Closing for now as this isn't planned and somehow keeps reappearing on my board.