Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing NuGetVersion causes significant GC pressure #12630

Closed
Erarndt opened this issue Jun 5, 2023 · 1 comment · Fixed by NuGet/NuGet.Client#5202
Closed

Parsing NuGetVersion causes significant GC pressure #12630

Erarndt opened this issue Jun 5, 2023 · 1 comment · Fixed by NuGet/NuGet.Client#5202
Assignees
@Erarndt
Labels
Community PRs (and linked Issues) created by someone not in the NuGet team Functionality:Restore Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug
Milestone
6.7

Comments

@Erarndt
Copy link

Erarndt commented Jun 5, 2023

The code that parses NuGetVersion from strings indirectly uses .NET's Version.TryParse to parse the version portion of the string. When a typical restore can be thousands upon thousands of NuGetVersion objects floating around, this API on .NET Framework is not good enough as it indirectly uses String.Split under the covers and is very inefficient.
@Erarndt Erarndt mentioned this issue Jun 5, 2023
Merged
6 tasks
@ghost
Copy link

ghost commented Jun 5, 2023

Issue is missing Type label, remember to add a Type label

@ghost ghost added the missing-required-type The required type label is missing. label Jun 5, 2023
@zivkan zivkan added Type:Bug Tenet:Performance Performance issues and removed missing-required-type The required type label is missing. labels Jun 6, 2023
@nkolev92 nkolev92 added Functionality:Restore Priority:2 Issues for the current backlog. Community PRs (and linked Issues) created by someone not in the NuGet team labels Jun 13, 2023
@nkolev92 nkolev92 added this to the 6.7 milestone Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erarndt Erarndt

Labels
Community PRs (and linked Issues) created by someone not in the NuGet team Functionality:Restore Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug
Projects
None yet
Milestone
6.7
Development

Successfully merging a pull request may close this issue.

Avoid allocations while parsing NuGetVersion from strings Erarndt/NuGet.Client
3 participants
@nkolev92 @zivkan @Erarndt