Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unreliable assembly location code with reliable one #12650

Closed
erdembayar opened this issue Jun 9, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5223
Closed

Replace unreliable assembly location code with reliable one #12650

erdembayar opened this issue Jun 9, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5223
Assignees
Labels
Priority:2 Issues for the current backlog. Tenet:Reliability Crashes, hangs etc. Type:Bug
Milestone

Comments

@erdembayar
Copy link
Contributor

erdembayar commented Jun 9, 2023

NuGet Product Used

NuGet.exe

Product Version

VS, dotnet, nuget.exe

Worked before?

n/a

Impact

None

Repro Steps & Context

When code inlining happens then Assembly.GetExecutingAssembly().Location may point to wrong location.
So we need to replace with typeof(T).Assembly.Location for reliability. This concern came up during review of another internal repo.

Verbose Logs

No response

@erdembayar erdembayar self-assigned this Jun 9, 2023
@nkolev92 nkolev92 added Priority:2 Issues for the current backlog. Product:NuGet.exe NuGet.exe Tenet:Reliability Crashes, hangs etc. and removed Product:NuGet.exe NuGet.exe labels Jun 13, 2023
@nkolev92 nkolev92 added this to the 6.7 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:2 Issues for the current backlog. Tenet:Reliability Crashes, hangs etc. Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@nkolev92 @erdembayar and others