Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Don't allocate as many Task instances #12659

Closed
drewnoakes opened this issue Jun 16, 2023 · 1 comment · Fixed by NuGet/NuGet.Client#5242
Closed

Performance: Don't allocate as many Task instances #12659

drewnoakes opened this issue Jun 16, 2023 · 1 comment · Fixed by NuGet/NuGet.Client#5242
Labels
Tenet:Performance Performance issues Type:Bug
Milestone
6.7

Comments

@drewnoakes
Copy link

When a Task completes successfully, it's Task object may be reused.

Currently NuGet.Client allocates a lot of task objects in places where singletons could be used.

Changing this would reduce allocations overall and reduce the overhead of async code.
@ghost
Copy link

ghost commented Jun 16, 2023

@drewnoakes Issue is missing Type label, remember to add a Type label

@ghost ghost added the missing-required-type The required type label is missing. label Jun 16, 2023
@drewnoakes drewnoakes mentioned this issue Jun 16, 2023
Merged
8 tasks
@ghost ghost removed the missing-required-type The required type label is missing. label Jun 16, 2023
@donnie-msft donnie-msft added the Tenet:Performance Performance issues label Jun 19, 2023
@nkolev92 nkolev92 added this to the 6.7 milestone Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tenet:Performance Performance issues Type:Bug
Projects
None yet
Milestone
6.7
Development

Successfully merging a pull request may close this issue.

Don't allocate as many Task instances NuGet/NuGet.Client
3 participants
@drewnoakes @nkolev92 @donnie-msft