Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore task dumps stack because TaskCanceledException should be OperationCanceledException #12700

Closed
danmoseley opened this issue Jun 26, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5276
Closed

Restore task dumps stack because TaskCanceledException should be OperationCanceledException #12700

danmoseley opened this issue Jun 26, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5276
Labels
Category:Quality Week Issues that should be considered for quality week Community PRs (and linked Issues) created by someone not in the NuGet team Functionality:Restore Priority:2 Issues for the current backlog. Type:Bug
Milestone
6.7

Comments

@danmoseley
Copy link

Moving from dotnet/msbuild#7145

The RestoreTask tries to account for a cancellation token, but in its catch for it, it checks for a TaskCanceledException instead of an OperationCanceledException.

This catch should be for OperationCanceledException thrown here.
@danmoseley danmoseley mentioned this issue Jun 26, 2023
Merged
8 tasks
@nkolev92 nkolev92 added Priority:2 Issues for the current backlog. Category:Quality Week Issues that should be considered for quality week Community PRs (and linked Issues) created by someone not in the NuGet team labels Jun 26, 2023
@nkolev92 nkolev92 added this to the 6.7 milestone Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category:Quality Week Issues that should be considered for quality week Community PRs (and linked Issues) created by someone not in the NuGet team Functionality:Restore Priority:2 Issues for the current backlog. Type:Bug
Projects
None yet
Milestone
6.7
Development

Successfully merging a pull request may close this issue.

fix crash on cancel in Restore task danmoseley/NuGet.Client
3 participants
@nkolev92 @zivkan @danmoseley