NuGet warnings and errors for non-SDK PackageReference projects disappear from VS's error list

[zivkan]

NuGet Product Used

Visual Studio Package Management UI

Product Version

VS17.7

Worked before?

No response

Impact

It's more difficult to complete my work

Repro Steps & Context

Create a .NET Framework (non-SDK style) project, and using PackageReference as the package format, install NuGet.Protocol version 6.6.0, and Newtonsoft.Json 9.0.1.

The first time you try to build, you'll see a NU1605 warning in the Error List. Try to build a second time, and the NU1605 disappears. Closing the project and reloading it will add it to the Error List again after the first restore/build, until the second time you build.

Verbose Logs

No response

[nkolev92]

Do you know if this is a regression?

[nkolev92]

I did some minor digging, not sure if it's a regression, but for legacy projects, the build sometimes short circuits all the listeners, so the errors would get cleared since restore never gets run and the build itself (?) cleans the error list.

[zivkan]

I just tested VS2019 (16.11), and it's happening there too (from a customer perspective, I didn't debug to check the listeners as you did). So, if it's a regression, it's a very old regression. Or, if the regression is caused by another component in VS, maybe they backported their change into 16.11.

[nkolev92]

TBH, I'm gonna guess this was an "always worked this way" behavior. I don't have VS 2017 installed, but I'm willing to guess it behaves the same way.

IMO, if VS 2017 behaves the same way, we should close this as "by design" or "known issue/limitation" wyt?

[zivkan]

It's a bad customer experience, so I very much disagree with by design. I can't think of any reason why this behaviour would be desirable.

But if it's too low value to spend effort on, especially since customers are migrating to SDK style projects, then the team can choose to close as "Won't Fix".

[nkolev92]

This would only happen if you run build without really changing anything.

Personally, the lack of customer signal makes me think it's super low priority.

[nkolev92]

Similar issue popped up in #13521.

[xperiandri]

The same happens for F# projects all the time

[nkolev92]

The same happens for F# projects all the time

F# projects are .NET SDK based.

If you're seeing problems for that, please file a separate issue.