Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSBuildRestoreUtility.GetRestoreAuditProperties needs a breaking change to read NuGetAuditSuppress items #13313

Closed
advay26 opened this issue Mar 12, 2024 · 0 comments · Fixed by NuGet/NuGet.Client#5679
Closed

MSBuildRestoreUtility.GetRestoreAuditProperties needs a breaking change to read NuGetAuditSuppress items #13313

advay26 opened this issue Mar 12, 2024 · 0 comments · Fixed by NuGet/NuGet.Client#5679
Assignees
@advay26
Labels
Area:NuGetAudit Category:BreakingChange Functionality:Restore Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Type:DCR Design Change Request

Comments

@advay26
Copy link
Contributor

advay26 commented Mar 12, 2024 •
edited

NuGet Product(s) Affected

NuGet.exe, Visual Studio Package Management UI, Visual Studio Package Manager Console, MSBuild.exe, dotnet.exe, NuGet SDK

Current Behavior

The GetRestoreAuditProperties() method in NuGet.Commands.MSBuildRestoreUtility currently just takes a single IMSBuildItem specItem input, which contains all the relevant NuGetAudit MSBuild Properties.

Desired Behavior

We're adding a new MSBuild Item for NuGetAudit with NuGetAuditSuppress. To read this item, we will need to update the method signature for GetRestoreAuditProperties() to accept an additional parameter, System.Collections.Generic.IList<string> suppressionItems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@advay26 advay26

Labels
Area:NuGetAudit Category:BreakingChange Functionality:Restore Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Type:DCR Design Change Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable advisory suppressions in CLI restore for PackageReference projects NuGet/NuGet.Client
1 participant
@advay26