Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PerfWatson] UIDelay: nuget.packagemanagement.visualstudio.dll!NuGet.PackageManagement.VisualStudio.VSMSBuildNuGetProjectSystem+<>c__DisplayClass_0+<<AddReference>b__>d.MoveNext #2285

Closed
deepakaravindr opened this issue Mar 10, 2016 · 4 comments
Closed

[PerfWatson] UIDelay: nuget.packagemanagement.visualstudio.dll!NuGet.PackageManagement.VisualStudio.VSMSBuildNuGetProjectSystem+<>c__DisplayClass_0+<<AddReference>b__>d.MoveNext #2285

deepakaravindr opened this issue Mar 10, 2016 · 4 comments
Assignees
@emgarten
Labels
Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug
Milestone
3.5 Beta2

Comments

@deepakaravindr
Copy link

This is a perf bug where the total time spent by VSMSBuildNuGetProjectSystem.AddReference on the UI thread is significant. There is no specific scenario, but that, around 5% of the time, total time spent on AddReference could be greater than 5 secs and lesser than 10 secs.
@deepakaravindr
Copy link
Author

One possible improvement to the method could be to perform any necessary IO operations to msbuild project file off the UI thread.

@yishaigalatzer yishaigalatzer added this to the 3.5 Beta milestone Mar 10, 2016
@yishaigalatzer yishaigalatzer added Priority:2 Issues for the current backlog. Tenet:Performance Performance issues labels Mar 10, 2016
@yishaigalatzer yishaigalatzer modified the milestones: 3.5 Beta, 3.5 RC Apr 8, 2016
@rrelyea rrelyea assigned emgarten and unassigned deepakaravindr Apr 19, 2016
@emgarten emgarten mentioned this issue Apr 21, 2016
Closed
@emgarten
Copy link
Member

Checked into dev with NuGet/NuGet.Client@e3d73b2

This still needs to go into 3.4.5 when the branch is created.

@emgarten emgarten closed this as completed May 4, 2016
@rrelyea rrelyea modified the milestones: 3.4.5, 3.5 RC May 4, 2016
@rrelyea
Copy link
Contributor

rrelyea commented May 4, 2016

Moving to 3.4.5 so we can track that.

@emgarten
Copy link
Member

Ported to 3.4.5 NuGet/NuGet.Client@5045012

@zhili1208 zhili1208 modified the milestones: 3.5 Beta2, 3.4.5 Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emgarten emgarten

Labels
Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug
Projects
None yet
Milestone
3.5 Beta2
Development

No branches or pull requests
5 participants
@yishaigalatzer @deepakaravindr @emgarten @zhili1208 @rrelyea