New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PerfWatson] UIDelay: nuget.packagemanagement.visualstudio.dll!NuGet.PackageManagement.VisualStudio.VSMSBuildNuGetProjectSystem+<>c__DisplayClass_0+<<AddReference>b__>d.MoveNext #2285

Closed
deepakaravindr opened this Issue Mar 10, 2016 · 4 comments

Comments

Projects
None yet
5 participants
@deepakaravindr
Member

deepakaravindr commented Mar 10, 2016

This is a perf bug where the total time spent by VSMSBuildNuGetProjectSystem.AddReference on the UI thread is significant. There is no specific scenario, but that, around 5% of the time, total time spent on AddReference could be greater than 5 secs and lesser than 10 secs.

@deepakaravindr

This comment has been minimized.

Show comment
Hide comment
@deepakaravindr

deepakaravindr Mar 10, 2016

Member

One possible improvement to the method could be to perform any necessary IO operations to msbuild project file off the UI thread.

Member

deepakaravindr commented Mar 10, 2016

One possible improvement to the method could be to perform any necessary IO operations to msbuild project file off the UI thread.

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Apr 25, 2016

Contributor

Checked into dev with NuGet/NuGet.Client@e3d73b2

This still needs to go into 3.4.5 when the branch is created.

Contributor

emgarten commented Apr 25, 2016

Checked into dev with NuGet/NuGet.Client@e3d73b2

This still needs to go into 3.4.5 when the branch is created.

@emgarten emgarten closed this May 4, 2016

@rrelyea rrelyea modified the milestones: 3.4.5, 3.5 RC May 4, 2016

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea May 4, 2016

Contributor

Moving to 3.4.5 so we can track that.

Contributor

rrelyea commented May 4, 2016

Moving to 3.4.5 so we can track that.

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten May 20, 2016

Contributor

Ported to 3.4.5 NuGet/NuGet.Client@5045012

Contributor

emgarten commented May 20, 2016

Ported to 3.4.5 NuGet/NuGet.Client@5045012

@zhili1208 zhili1208 modified the milestones: 3.5 Beta2, 3.4.5 Jun 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment