-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NuGet 3.4.3 Push doesn't work with OctopusDeploy #2661
Comments
The headers are not corrupt, they are now valid upload headers. We started a chat with octopus deploy to figure out why the server is being strict about them. We did test with all nuget servers to validate this change. Octopus deploy wasn't on our radar unfortunately. Will loop back when we get more progress with octopus folks |
Fair enough, I should probably read the header RFCs before making assumptions like that. Figures they'd use something strange as a separator in an HTTP header. (While i've made plenty use of mime-multipart uploads, I've never actually used filename*.) It seems as though filename* isn't being parsed on their end, and they're trying to save a file named: utf-8''package.nupkg if that's helpful. If you need octopus logs, or want to put me in touch with someone from their end to provide more info i'd be more than happy to help. |
OctopusDeploy is fixing in next patch release. (Their RegEx no longer worked with our change to use filename* in contentdisposition) |
User-Agent: NuGet Command Line/3.4.3.855 (Microsoft Windows NT 6.2.9200.0)
User-Agent: NuGet Command Line/3.3.0.212 (Microsoft Windows NT 6.2.9200.0)
Headers were captured with Fiddler.
Issue discovered while attempting to push a NuGet package to Octopus for Deployment using NuGet.exe
Have downgraded to NuGet 3.3
Package upload command:
NuGet.exe push package.nupkg https://REDACTED/octopus/nuget/packages
The text was updated successfully, but these errors were encountered: