-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5-beta2] Package restore fails to restore "legacy" packages #3208
Comments
@rrelyea might be a RTM blocker for 3.5 |
Please give us detailed repro steps. (would be great to be minimal size, if possible). |
Output (even without "NoCache"):
|
Additional testing: without specifying the config, it works (but I have been using this packages.config for years). |
which setting in the config file is causing this issue? |
As it is open source, the setting is located here: https://github.com/GitTools/GitLink/blob/develop/src/nuget.config
If I run NuGet.exe without any config (but for the sln), it still recognizes this config file and then it does work (and correctly uses the ../lib folder). I think the (machine / user) configs don't merge when explicitly specified? |
@mishra14 - can you please determine when this changed behavior? broken since 3.4.4, or before? |
Latest nightly build (rc1?) seems to work fine for both cases. |
I repro'd the error on my machine. I tried a few of the exe's available on nuget.org. Results -
@GeertvanHorrik : The new exe's throw errors on restore when a config file is specified, because if you specify a config file then all the other (default, etc) config files are ignored. you can read more about it on the NuGet Configuration File Docs. As a reference, you can see the config files used in the console output -
But with specified config -
Let us know if this clarifies/fixes the issue. |
@mishra14 Thanks for the detailed report Ankit. I will remove the explicit config specifications from all builds (we had to add that for 2.8.6 as you mentioned) to make this work everywhere. |
@GeertvanHorrik : I have updated the table for v2.8.6 - In that version, specifying the config file works fine. Also, if this fixes the issue, let us know. We can then close the bug. |
Let's assume this breaking change is caused by (v3.4.3). I will update my usages so this one can be closed. Thanks for all the help. |
This feature works great in previous versions of NuGet. Suddenly it stopped working in 3.5-beta2:
So I need 3.5-beta2 to support .net core projects, and I need an older version to support non-.net core projects.
The text was updated successfully, but these errors were encountered: