-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPS out of sync with Restore with larger solutions that haven't turned on LSL (lightweight solution restore) #4307
Comments
Will have to live with this, as it doesn't block the user. Need better fix for large projects. |
Pulling back to 4.0rtm -- may consider fix...depending how much the fix for #4617 (statusbar logging, output loggging and warning/error logging) improves things. |
@jainaashish - not sure we are taking, but please investigate RTM options on this one. |
Proposed solution: Also, note this delay will not impact other cases where either we already got all the nominations or there isn’t any .net core based project in solution. These scenarios will continue to work as is and will have no performance overhead because of this change. |
Hey, coordinate with us on this: dotnet/project-system#1600. We're nominating too late as it is. |
@davkean are you targeting your issue for RTM? since this is impacting auto restore performance big time so we need to get something done for RTM. |
Not expecting a NuGet change for RTM at this point, and will solve perf issues with improved logging. @davkean ping back if you need a follow on change from NuGet for this for RTM. |
one more internal vsts bug# 387758 |
I'm not sure if this is the same root bug, but I am having an error display while loading Package Management Console (PMC) prompt Update: Also error is not affected by changing the solution setting 'Lightweight Load' to default, enabled, or disable. Originally set to default. Just discovered the setting after I posted. |
Out of time for 4.3 |
This is still happening for some of the solutions where all the projects are not nominated even after delaying until 10 secs so re-opening this again. We'll coordinate with Project System to fix it with proper design. |
Bringing this into 4.4 we have to get the right design in place to fix it once and for all. It impacts other scenarios as well like Test Explorer not able to discover tests on solution load since project is being nominated late. |
This issue was moved to dotnet/sdk#1607 |
From @srivatsn
please investigate to understand if this should be rc3 or rtm issue?
Opening Projectsystem.sln from https://github.com/srivatsn/roslyn-project-system/tree/dogfood/src
Show these errors in the package manager window:
Error occurred while restoring NuGet packages: The operation failed as details for project ProjectSystemDogfoodSetup could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project MSBuild could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Composition could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.VisualBasic.VS could not be loaded.
Restoring NuGet packages...
Time Elapsed: 00:00:05.8245080
========== Finished ==========
The text was updated successfully, but these errors were encountered: