Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPS out of sync with Restore with larger solutions that haven't turned on LSL (lightweight solution restore) #4307

Closed
rrelyea opened this issue Jan 17, 2017 · 14 comments
Closed

CPS out of sync with Restore with larger solutions that haven't turned on LSL (lightweight solution restore) #4307

rrelyea opened this issue Jan 17, 2017 · 14 comments
Assignees
@jainaashish
Labels
Functionality:Restore Priority:1 High priority issues that must be resolved in the current sprint. Style:PackageReference Type:Bug
Milestone
4.4

Comments

@rrelyea
Copy link
Contributor

rrelyea commented Jan 17, 2017

From @srivatsn
please investigate to understand if this should be rc3 or rtm issue?
Opening Projectsystem.sln from https://github.com/srivatsn/roslyn-project-system/tree/dogfood/src

Show these errors in the package manager window:

Error occurred while restoring NuGet packages: The operation failed as details for project ProjectSystemDogfoodSetup could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.Managed.TestServices.UnitTests could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project MSBuild could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Composition could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.VisualStudio.ProjectSystem.VisualBasic.VS could not be loaded.
Restoring NuGet packages...
Time Elapsed: 00:00:05.8245080
========== Finished ==========
@rrelyea rrelyea added this to the 4.0 RC3 milestone Jan 17, 2017
@rrelyea rrelyea modified the milestones: 4.0.1, 4.0 RC3 Jan 24, 2017
@rrelyea
Copy link
Contributor Author

rrelyea commented Jan 24, 2017

Will have to live with this, as it doesn't block the user. Need better fix for large projects.
People should use LSL for large solutions...and it will work better

@jainaashish jainaashish mentioned this issue Jan 27, 2017
Closed
@rainersigwald rainersigwald mentioned this issue Feb 2, 2017
Closed
@jeffkl jeffkl mentioned this issue Feb 2, 2017
Closed
2 tasks
@rrelyea
Copy link
Contributor Author

rrelyea commented Feb 8, 2017

@dtivel was investigating #4474, got the customer solution, and ran into this same problem.

@rrelyea rrelyea changed the title CPS out of sync with Restore? CPS out of sync with Restore with larger solutions that haven't turned on LSL (lightweight solution restore, formerly called DPL) Feb 9, 2017
@zhili1208 zhili1208 mentioned this issue Feb 15, 2017
Closed
@emgarten emgarten mentioned this issue Feb 15, 2017
Closed
@rrelyea rrelyea modified the milestones: 4.0 RTM, 4.0.1 Feb 16, 2017
@rrelyea
Copy link
Contributor Author

rrelyea commented Feb 16, 2017

Pulling back to 4.0rtm -- may consider fix...depending how much the fix for #4617 (statusbar logging, output loggging and warning/error logging) improves things.

@rrelyea
Copy link
Contributor Author

rrelyea commented Feb 17, 2017

@jainaashish - not sure we are taking, but please investigate RTM options on this one.

@jainaashish
Copy link
Contributor

Proposed solution:
Delay auto restore until we are expecting some nominations for .net core projects. This delay won’t be indefinite and would be capped by 10 secs so even after 10 secs delay, we still haven’t got all the nominations, we’ll continue with auto restore which will fails with the current error. During this delay UI won’t be freeze so user will still be able to carry out any other operation in VS. And this delay will also be in form of 2 secs so every 2 secs it will check if it has all the nominations then it will continue without further delay.

Also, note this delay will not impact other cases where either we already got all the nominations or there isn’t any .net core based project in solution. These scenarios will continue to work as is and will have no performance overhead because of this change.

@jainaashish jainaashish mentioned this issue Feb 22, 2017
Merged
@davkean
Copy link

davkean commented Feb 23, 2017

Hey, coordinate with us on this: dotnet/project-system#1600. We're nominating too late as it is.

@jainaashish
Copy link
Contributor

@davkean are you targeting your issue for RTM? since this is impacting auto restore performance big time so we need to get something done for RTM.

@DoRonMotter
Copy link

Not expecting a NuGet change for RTM at this point, and will solve perf issues with improved logging. @davkean ping back if you need a follow on change from NuGet for this for RTM.

@DoRonMotter DoRonMotter modified the milestones: Future-1, 4.0 RTM Feb 24, 2017
@emgarten emgarten mentioned this issue Mar 6, 2017
Closed
@jainaashish
Copy link
Contributor

one more internal vsts bug# 387758

@wizarrc
Copy link

wizarrc commented Mar 16, 2017 •
edited
Loading

I'm not sure if this is the same root bug, but I am having an error display while loading Package Management Console (PMC) prompt PM> when the solution is still loading. I receive the error 'The operation failed as details for project insert project name could not be loaded.' preventing the prompt from displaying. I can work around it by closing the PMC window, restart vs and load the solution, wait for all projects to load, and open the PMC window again. Error occurs on VS 2017 RTM version up to date as of today with 'Lightweight solutions load for all solutions' checked or not.

Update: Also error is not affected by changing the solution setting 'Lightweight Load' to default, enabled, or disable. Originally set to default. Just discovered the setting after I posted.

@rrelyea rrelyea added this to the 4.3 milestone Mar 21, 2017
@rrelyea rrelyea removed this from the Future-1 milestone Mar 21, 2017
@emgarten emgarten mentioned this issue Apr 23, 2017
Closed
This was referenced Jun 8, 2017
Closed
Closed
@rrelyea rrelyea modified the milestones: 4.4, 4.3 Jun 28, 2017
@rrelyea
Copy link
Contributor Author

rrelyea commented Jun 28, 2017

Out of time for 4.3

@jainaashish
Copy link
Contributor

This is still happening for some of the solutions where all the projects are not nominated even after delaying until 10 secs so re-opening this again. We'll coordinate with Project System to fix it with proper design.

@jainaashish jainaashish reopened this Aug 22, 2017
@jainaashish jainaashish modified the milestones: Backlog, 4.4 Aug 22, 2017
@jainaashish jainaashish added the Priority:1 High priority issues that must be resolved in the current sprint. label Aug 22, 2017
@jainaashish jainaashish modified the milestones: 4.4, Backlog Aug 31, 2017
@jainaashish
Copy link
Contributor

Bringing this into 4.4 we have to get the right design in place to fix it once and for all. It impacts other scenarios as well like Test Explorer not able to discover tests on solution load since project is being nominated late.

@mishra14 mishra14 changed the title CPS out of sync with Restore with larger solutions that haven't turned on LSL (lightweight solution restore, formerly called DPL) CPS out of sync with Restore with larger solutions that haven't turned on LSL (lightweight solution restore) Sep 26, 2017
@mishra14 mishra14 mentioned this issue Sep 26, 2017
Closed
@mishra14
Copy link
Contributor

This issue was moved to dotnet/sdk#1607

@jtkech jtkech mentioned this issue Jun 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jainaashish jainaashish

Labels
Functionality:Restore Priority:1 High priority issues that must be resolved in the current sprint. Style:PackageReference Type:Bug
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
6 participants
@davkean @wizarrc @rrelyea @mishra14 @jainaashish @DoRonMotter