Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS 2017 RC3 crashes on using update from Solution-wide package management #4474

Closed
davkean opened this issue Feb 2, 2017 · 11 comments
Closed
Assignees
Labels
Milestone

Comments

@davkean
Copy link

davkean commented Feb 2, 2017

From @glatzert on February 1, 2017 10:29

Trying to update packages via the solution-wide nuget package manager, will stop without further notice and keep VS non-responding.

I tried a smaller solution, where the update works, but with a mid-sized one (about 25-30 Projects) the update process will always make VS hang. Single projects will get the update, so if you restart multiple times and try again and again it will eventually work.

Copied from original issue: aspnet/Tooling#983

@rrelyea
Copy link
Contributor

rrelyea commented Feb 2, 2017

Already addressed in RTM?

@rrelyea rrelyea added the help wanted Considered good issues for community contributions. label Feb 3, 2017
@rrelyea rrelyea assigned dtivel and unassigned alpaix Feb 3, 2017
@rrelyea rrelyea removed the help wanted Considered good issues for community contributions. label Feb 3, 2017
@dtivel
Copy link
Contributor

dtivel commented Feb 3, 2017

@glatzert, do you have a repro solution you can share?

@rrelyea rrelyea modified the milestones: 4.0 RTM, 4.0 RC4 Feb 5, 2017
@glatzert
Copy link

glatzert commented Feb 6, 2017

I could give you my solution, but we refrained from moving to VS'17, since there have been to much Problems with that.
If you provide me an email or OneDrive, i'd happily drop of a zip-file.

@dtivel
Copy link
Contributor

dtivel commented Feb 6, 2017

@glatzert, before I see your solution do I need to sign an NDA?

It's best if you remove any IP or sensitive information before sharing. You can send a sanitized repro solution to dtivel @ microsoft.com.

@glatzert
Copy link

glatzert commented Feb 6, 2017

I sent you an eMail.
NDA is not neccessary - feel free let me learn something about my Project, if there are smelly things :)

@rrelyea
Copy link
Contributor

rrelyea commented Feb 8, 2017

@dtivel - can you help me understand the state of this issue. Summary?

@dtivel
Copy link
Contributor

dtivel commented Feb 8, 2017

I have not reproduced a crash in the solution-wide NuGet Package Manager on VS 2017 RC3 with @glatzert's solution.

The solution must first be migrated from an earlier version of Visual Studio. There are several migration issues. For example, I hit this non-fatal error during migration: dotnet/project-system#1213 / dotnet/project-system#1290. For me the actual restore operation did not crash Visual Studio or make Visual Studio unresponsive.

@glatzert
Copy link

glatzert commented Feb 8, 2017

Just to make sure, we are talking about the same things:
The restore itself did not pose a problem.
Problem occured when I tried to update a package for multiple (say all) projects from the nuget solution wide management. That would not succeed in our case.

BUT my current machine went aaaaalll the way from dotnet beta5 to the current state - so that might perhaps be some whatsoever side effect.
If you tell me, everything will be fine once VS2017 RTMs, I will happily format this machine and start over from the beginning without asking again (as soon as RTM is available) ;-)

@dtivel
Copy link
Contributor

dtivel commented Feb 8, 2017

I think we're on the same page, @glatzert. After migrating the solution (part automated, part manual), I did open NuGet Package Manager for the solution and tried to update all packages solution-wide that needed updating. This update succeeded for me and did not result in a crash or VS becoming unresponsive.

It would be great if you could try your scenario on the latest RC build (RC4), which was released on February 7th. You can get it either through this link or by updating within Visual Studio itself.

@dtivel dtivel closed this as completed Feb 8, 2017
@glatzert
Copy link

I copied my solution to some path on my machine and tried migrating, and updating.
Worked fine 👍

After I used my solution with TFSVC connected Things are not working that smoothly, but switching to lightweight loading and back solved that so I can move on - thanks for your assistance.

@dtivel
Copy link
Contributor

dtivel commented Feb 10, 2017

Thanks for letting me know, @glatzert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants