Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issues with new SDK #1660

Closed
1 of 2 tasks
jeffkl opened this issue Feb 2, 2017 · 1 comment
Closed
1 of 2 tasks

Tracking issues with new SDK #1660

jeffkl opened this issue Feb 2, 2017 · 1 comment
Labels
Milestone

Comments

@jeffkl
Copy link
Contributor

jeffkl commented Feb 2, 2017

Tracking things found when dogfooding the new SDK

Blocking Issues

Non-block issues

  1. Restore error when specifying two or more target frameworks (CPS out of sync with Restore with larger solutions that haven't turned on LSL (lightweight solution restore) NuGet/Home#4307)
    Error occurred while restoring NuGet packages: The operation failed as details for project X could not be loaded.
  2. Can't override properties like OutputType in a .props file (Can't override properties like OutputType in a .props file sdk#850)

Workarounds

A list of things we had to work around that we can undo after bugs are fixed

Hacks

Hacks put in place to make progress that we should undo as we get a little further

  1. Using BuildTools for signing and had to set ToolsDir and BuildToolsTaskDir and import sign.targets.

Open Questions

A list of things we need to solve to make progress.

  • How do we want to do signing? Prefer not to use BuildTools anymore?
  • How to determine if we're building .NET Framework or .NET Core during the outer build. Only seems to be set in .targets.
    This was solved by keying off of the property TargetFramework instead of TargetFrameworkIdentifier. TargetFramework is something like net46 so we'll need to be careful with conditions.

Needs Investigation

Mono support

Need to determine how/if this can support Mono.

Related to #1638 and #1639.

@rainersigwald
Copy link
Member

For signing, using the SDK implies using Roslyn 2.0, which has /publicsign+. We should use that. We shouldn't need BuildTools for anything when we're all in on the SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants