Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when projectreference casing and file system casing differ project.assets.json gets regenerated #7823

Open
kingerja opened this issue Feb 22, 2019 · 2 comments
Labels
Functionality:Restore Partner:1ES Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Style:PackageReference Type:Bug

Comments

@kingerja
Copy link

NuGet product used (NuGet.exe | VS UI | Package Manager Console | dotnet.exe):
msbuild 15.9.21.664
using msbuild /t:Restore

VS version (if appropriate):
15.9.6

OS version (i.e. win10 v1607 (14393.321)):
win10 v 1809 (17763.253)

Detailed repro steps so we can see the same problem

  1. File system has directory structure like.
    Foo\Bar\ProjectA.csproj

  2. Project B has project reference foo\bar

  3. msbuild /restore Foo\Bar\ProjectA.csproj
    copy off the project.assets.json file from projectA.csproj.

  4. msbuild /restore projectB.csproj
    windiff new ProjectA.csproj project.assets.json with the copied off one.

Note the casing different which breaks incremental builds.

casing.zip

@dominoFire dominoFire added Product:MSBuildSDKResolver The NuGet powered SDK resolver. Owned by MSBuild team Type:Bug labels Feb 23, 2019
@dominoFire dominoFire added this to the Backlog milestone Feb 23, 2019
@anangaur
Copy link
Member

Related issue for lock files: #7840

@nkolev92 nkolev92 added Functionality:Restore Category:Quality Week Issues that should be considered for quality week Priority:2 Issues for the current backlog. Partner:1ES and removed Triage:Investigate Pipeline:Icebox Priority:2 Issues for the current backlog. Category:Quality Week Issues that should be considered for quality week labels Sep 13, 2023
@nkolev92 nkolev92 removed this from the Backlog milestone Sep 13, 2023
@nkolev92
Copy link
Member

Casing.zip

I have another scenario that's broken. In my case, standard restore evaluation and static graph restore are self-consistent, but don't work when run in combination. Example, msbuild /t:restore and msbuild /t:restore /p:RestoreUseStaticGraphEvaluation="true" does not no-op.

@jeffkl jeffkl added Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Pipeline:Icebox labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Restore Partner:1ES Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Style:PackageReference Type:Bug
Projects
None yet
Development

No branches or pull requests

7 participants