Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate dgspec when customer triggers VS Feedback #8605

Closed
zivkan opened this issue Sep 18, 2019 · 0 comments · Fixed by NuGet/NuGet.Client#4733
Closed

Regenerate dgspec when customer triggers VS Feedback #8605

zivkan opened this issue Sep 18, 2019 · 0 comments · Fixed by NuGet/NuGet.Client#4733
Assignees
@zivkan
Labels
Priority:2 Issues for the current backlog. Product:VS.Client Type:DCR Design Change Request
Milestone
6.4

Comments

@zivkan
Copy link
Member

zivkan commented Sep 18, 2019 •
edited
Loading

The initial implementation of NuGetFeedbackDiagnosticFileProvider just replicated what was being done before: include a static file.

This has the risk that if multiple solutions were restored, the static file might not be related to the VS instance that is being used to report a problem with the feedback tool.

Ideas for improvement:

  • Regen dgspec with static filename when feedback triggered
  • Regen dgspec with unique filename when feedback triggered
  • Only write dgspec when feedback triggered, not on every PR restore
@zivkan zivkan added Product:VS.Client Type:DCR Design Change Request labels Sep 18, 2019
@zivkan zivkan added this to the Backlog milestone Sep 18, 2019
@nkolev92 nkolev92 added Category:Quality Week Issues that should be considered for quality week Priority:2 Issues for the current backlog. labels Apr 30, 2020
@zivkan zivkan self-assigned this Sep 7, 2021
@zivkan zivkan modified the milestones: Backlog, Sprint 2021-09 Sep 7, 2021
@zivkan zivkan removed the Category:Quality Week Issues that should be considered for quality week label Sep 7, 2021
@zivkan zivkan modified the milestones: Sprint 2021-11, Sprint 2022-01 Jan 3, 2022
@aortiz-msft aortiz-msft removed this from the Sprint 2022-01 milestone Jan 4, 2022
@zivkan zivkan changed the title Improve NuGetFeedbackDiagnosticFileProvider Regenerate dgspec when customer triggers VS Feedback Jan 4, 2022
@zivkan zivkan mentioned this issue Jul 22, 2022
Merged
8 tasks
@jebriede jebriede added this to the 6.4 milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zivkan zivkan

Labels
Priority:2 Issues for the current backlog. Product:VS.Client Type:DCR Design Change Request
Projects
None yet
Milestone
6.4
Development

Successfully merging a pull request may close this issue.

Write DGSpec to zip file for VS Feedback NuGet/NuGet.Client
5 participants
@nkolev92 @zivkan @jebriede @heng-liu @aortiz-msft