New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using relative paths for package sources is problematic to use #865

Closed
pranavkm opened this Issue Jul 1, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@pranavkm
Member

pranavkm commented Jul 1, 2015

  • NuGet.exe (2.8.6) does not allow specifying a relative path
> nuget.exe source -config $PWD\NuGet.config add -Name RelativeSourceName -Source RelativePath
The source specified is invalid. Please provide a valid source.
  • Relative paths get overwritten by absolute paths when SavePackageSource is invoked. Reproes with NuGet 2.8.6 and 3.0.
@zhili1208

This comment has been minimized.

Show comment
Hide comment
@zhili1208

zhili1208 Dec 1, 2015

Contributor

"does not allow specifying a relative path" repro with 3.3, 2.10, the problem is from PathValidator.IsValidSource() in nuget.core.

"relative paths get overwritten" is fixed in NuGet/NuGet.Client@71801c8

Contributor

zhili1208 commented Dec 1, 2015

"does not allow specifying a relative path" repro with 3.3, 2.10, the problem is from PathValidator.IsValidSource() in nuget.core.

"relative paths get overwritten" is fixed in NuGet/NuGet.Client@71801c8

@yishaigalatzer yishaigalatzer modified the milestones: 3.4 Beta, 3.4 RTM Feb 25, 2016

@yishaigalatzer

This comment has been minimized.

Show comment
Hide comment
@yishaigalatzer

yishaigalatzer Mar 8, 2016

Some commands still fail here like "list". Moving out to 3.5 Beta, the plan is to remove dependency on nuget.core.dll and when that change happens more of these scenarios will start lighting up

yishaigalatzer commented Mar 8, 2016

Some commands still fail here like "list". Moving out to 3.5 Beta, the plan is to remove dependency on nuget.core.dll and when that change happens more of these scenarios will start lighting up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment