Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using relative paths for package sources is problematic to use #865

Closed
pranavkm opened this issue Jul 1, 2015 · 2 comments
Closed

Using relative paths for package sources is problematic to use #865

pranavkm opened this issue Jul 1, 2015 · 2 comments
Assignees
@zhili1208
Labels
Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:Bug
Milestone
3.5 Beta2

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Jul 1, 2015

  • NuGet.exe (2.8.6) does not allow specifying a relative path
> nuget.exe source -config $PWD\NuGet.config add -Name RelativeSourceName -Source RelativePath
The source specified is invalid. Please provide a valid source.
  • Relative paths get overwritten by absolute paths when SavePackageSource is invoked. Reproes with NuGet 2.8.6 and 3.0.
@pranavkm pranavkm mentioned this issue Jul 1, 2015
Closed
@yishaigalatzer yishaigalatzer added this to the 3.2.0-Beta milestone Jul 1, 2015
@yishaigalatzer yishaigalatzer added Type:Bug Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. labels Nov 21, 2015
@yishaigalatzer yishaigalatzer modified the milestones: 3.4, 3.3.0-Beta Nov 21, 2015
@zhili1208
Copy link
Contributor

"does not allow specifying a relative path" repro with 3.3, 2.10, the problem is from PathValidator.IsValidSource() in nuget.core.

"relative paths get overwritten" is fixed in NuGet/NuGet.Client@71801c8

@yishaigalatzer yishaigalatzer modified the milestones: 3.4 Beta, 3.4 RTM Feb 25, 2016
@yishaigalatzer
Copy link

Some commands still fail here like "list". Moving out to 3.5 Beta, the plan is to remove dependency on nuget.core.dll and when that change happens more of these scenarios will start lighting up

@yishaigalatzer yishaigalatzer modified the milestones: 3.5 Beta, 3.4 RTM Mar 8, 2016
@yishaigalatzer yishaigalatzer modified the milestones: 3.5 Beta, 3.5 RC Apr 8, 2016
@zhili1208 zhili1208 mentioned this issue May 5, 2016
Closed
@zhili1208 zhili1208 modified the milestones: 3.5 Beta2, 3.6 Beta Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhili1208 zhili1208

Labels
Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:Bug
Projects
None yet
Milestone
3.5 Beta2
Development

Successfully merging a pull request may close this issue.

moved PathValidator from NuGet.Core to NuGet.Configuration NuGet/NuGet.Client
3 participants
@pranavkm @yishaigalatzer @zhili1208