Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PM UI does not humanize the download count when 999,500 <= count <=999,999 #8800

Closed
karann-msft opened this issue Nov 8, 2019 · 1 comment · Fixed by NuGet/NuGet.Client#4255
Closed

PM UI does not humanize the download count when 999,500 <= count <=999,999 #8800

karann-msft opened this issue Nov 8, 2019 · 1 comment · Fixed by NuGet/NuGet.Client#4255
Assignees
@erdembayar
Labels
Functionality:VisualStudioUI Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Tenet:WorldReady Type:Bug
Milestone
Sprint 2021-09

Comments

@karann-msft
Copy link
Contributor

image
@karann-msft karann-msft changed the title PM UI does display the humanized download count when the count is between 999,500 and 999,999 (both inclusive) PM UI does not humanize the download count when 999,500 <= count <=999,999 Nov 8, 2019
@donnie-msft donnie-msft added this to the Backlog milestone Nov 8, 2019
@donnie-msft donnie-msft added the Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. label Nov 8, 2019
@donnie-msft
Copy link
Contributor

Logic at fault is here: UIUtility.cs. Basically, this doesn't handle rounding in the way it needs to for the formatting we want.

@aortiz-msft aortiz-msft added Priority:1 High priority issues that must be resolved in the current sprint. Tenet:WorldReady and removed Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. labels Aug 27, 2021
@erdembayar erdembayar modified the milestones: Backlog, Sprint 2021-09 Sep 7, 2021
@erdembayar erdembayar mentioned this issue Sep 9, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erdembayar erdembayar

Labels
Functionality:VisualStudioUI Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Tenet:WorldReady Type:Bug
Projects
None yet
Milestone
Sprint 2021-09
Development

Successfully merging a pull request may close this issue.

Handle download count round up to 1E+3K for when 999,500 <= count <=999,999 NuGet/NuGet.Client
5 participants
@erdembayar @karann-msft @heng-liu @donnie-msft @aortiz-msft